[FIXED] [Paladin][Retribution] Echo of the Highlord

[Flashmoo]

WoW Freakz spell link: Echo of the Highlord
Bug description: Echo of the Highlord is not dealing 10% every time you use Templar's Verdict or Divine Storm. Look at the number of TV/DS I used and number of EH.
Proof: proof TV ; proof DS


Retribution Paladin Guide PvE | In-Depth 7.3.5
Protection Paladin Guide PvE | In-Depth 7.3.5
Holy Paladin Guide PvE | In-Depth 7.3.5

[Elvenking]

Pls don't test spells on training dummy, they usually have 0 HP or other reasons which leads to spells not behaving properly.
I tested it quick in OG on dummy and echo did 0 dmg on dummy, then I went into a dungeon to test it on a boss and it triggered fine.
Although I could find one bug, the Echo does not copy 10% dmg of critical strikes, which is somehow reported in low priority bugs:
https://forum.wow-freakz.com/Paladin-Echo-of-the-Highlord-Critical-Strikes-t481702.html

Here 2 cases where it did not correct dmg:

(931k TV crit > 46k echo non-crit)


(1.02M TV crit > 51k echo non-crit)

It would be nice if you can screen your comat log too like this to properly debug failing cases.

Confirmed, crits have to be mimicked correctly.

[Quicksand]

https://forum.wow-freakz.com/FIXED-Paladin-Retribution-Echo-of-the-Highlord-Critical-Strikes-t482413.html

It won't necessarily hit for the same amount as the original spell, as it can crit additionally, but yeah, base damage should copy the damage after crit bonus.

Fixed.