[REJECTED] [Demon Hunter] [Vengeance] Vengeance not getting the aura modifier - 15% less damage

[Xtravagant]

Spell Links: Vengeance Demon Hunter

Bug Description: First of all, the important cut out of the 7.2.5 patch notes. There we can see the UH DK got a 5% damage increase to all abilities, and Vengeance DH got a 15% damage increase. When we check this data in SimC we get this - UH DK got these modifiers on spell damage, DoT damage and pet damage, as expected. However, when we check Demon Hunter - we can see that it didn't get any modifiers. I thought it might be somehow related to the fact that Vengeance is a tank and UH is a dps spec. But looking at the 7.2.5 database and at Blood DK specifically we can see that Blood got it's 15% damage buff and Vengeance didn't. This leads me to believe that Vengeance doesn't have it's aura correctly applied. This results in an overall 15% damage decrease for Vengeance.
Also, when looking at the -5% damage decrease on a couple of Vengeance spells in the 7.2.5 database, I can't seem to find where exactly in the current/previous versions of the patch notes (looked from 7.0.3 patch notes up to 7.2.5) did the nerf actually happen, my only guess is that it's related to this hotfix but even then the hotfix should target all abilities, and not those 7 only.

Demonic Guide

Havoc Raid Guide

[Quicksand]

https://github.com/simulationcraft/simc/commit/0998452d4a095ea2d42ebf57f297c8fb57ed3d1d#diff-4c0e553b3e2d9d40b8f793aecbbb5815R575

Basically what happened is that: they removed the 9% flat bonus from spells (making the passive give 0%), but they increased coefficients on each spell.

Take this for example: https://www.wow-freakz.com/spells.php?spell=187727
7.1.5: 193% AP
7.2.5: 243% AP

That is 243/193 = 1.2590 = 25% buff

Remove that 9% that DH lost due to their aura: 1.2590 * 0.91 = 1.1457 ~= 15%

So the actual increase to the spell remains 15%

THEN, couple weeks later, they added the 5% nerf: https://github.com/simulationcraft/simc/commit/b951d34880b968cc641e4fa431c3fec3598607af#diff-4c0e553b3e2d9d40b8f793aecbbb5815R3039

Please do not get lost in the details just yet, we intend to focus on more gamebreaking issues