[FIXED] [Rogue][Assassination] Poison Knives vs Agonizing Poison

[DeParanoia]

WoW Freakz spell link: Poison Knives, Agonizing Poison
Bug description: Poison Knives trait should increase the Mastery effect of Agonizing Poison by 12% (at 3/3 Poison Knives), right now it increases Agonizing Poison damage by 12.
Eg: Let's say you have 100% Mastery, for Agonizing Poison 50%, so 50*1.12=56%, that means: 3.5*1.56=5.46, NOT 3.5*1.5*1.12=5.88.
Proof:
https://youtube.com/watch?v=ioMUnsSxCHA:



Looking at this guy in the video we can see he has about 149% mastery (min 2:15) which means 74,5% (will round to 74%) increase to Agonizing, and 7.8% Agonizing Poison (min 5:42).
Doing the math we have:
74*1.12=82.88 (will round to 82) || Mastery*Poison Knives;
3.5*1.2*1.03*1.82=7.87 -> 7.8 on his tooltip || AP*MP*MA*Mastery;

If Poison Knives was added multiplicatively with AP then we would have:
3.5*1.2*1.03*1.74*1.12=8.43 which is waaay higher.

[Quicksand]

Too many info, sum it up please:

Do you say that ON FREAKZ it's MULTIPLICATIVE while on RETAIL it's ADDITIVE?

Update @ 03-08-2017, 19:03:27

Please clarify the math part: which one is on FREAKZ and which one is on RETAIL

Update @ 03-08-2017, 19:05:12

Also, you are completely wrong from the start: Poison Knives gives 6% increase on 3/3.

Update @ 03-08-2017, 19:08:46

It is not I who decided which one is multiplicative and which one is additive: http://www.askmrrobot.com/wow/theory/mechanic/spell/agonizingpoison?spec=RogueAssassination&&version=7_1_5_23420

I implemented it in the exact SAME ORDER and same manner. All the calculations are exactly done like on AskMrRobot.

[DeParanoia]

This is on freakz:

Quote:

3.5*1.2*1.03*1.74*1.12=8.43

This was on retail:

Quote:

74*1.12=82.88 (will round to 82) || Mastery*Poison Knives; 3.5*1.2*1.03*1.82=7.87 -> 7.8 on his tooltip || AP*MP*MA*Mastery;

Quicksand wrote:

Also, you are completely wrong from the start: Poison Knives gives 6% increase on 3/3.

Was hotfixed in 7.1 to 4% per point, but never modified ingame.
https://worldofwarcraft.com/en-us/news/20252902

Quote:

Poison Knives (Artifact Trait) no longer benefits twitch from Mastery. Damage per point increased to 4%.

(twitch is written, don't blame me)

[Quicksand]

Have you checked the askmrrobot page? Do forgive me, but so far 100% of the info was correct from there, so I trust it more than a random 7.1 hotfix. AskMrRobot lists 1% multiplicative increase to the total value per rank purchased. As of now it gives 2% for us. So it sort of doubled it, will make it to 1% per trait. Also, important to note, the tooltip for agonizing poison is completely broken. You cannot add 3.5% as a base point, it can only be integer value, so it still uses 4% for calculations. Also, tooltip calculates with 12% increase for Posion Knives, and I think other modifiers are calculated wrongly too. But the actual value you get is implementex exactly as it was om the last build of 7.1.5 (as it is on mrrobot, with the exception that i did 2% per Poison Knives trait instead of one). If I could, I would fix the tooltip, but with my current knowledge/tools I cannot. Only thing you can do is to believe me that the actual calculations are correct.

[DeParanoia]

I don't want to argue with you, but do the math on that guy's video.

[Quicksand]

I'll provide you concrete examples done by our server a bit later so I can convince you. Just so you can get an idea

[DeParanoia]

Documented a little more, I was wrong about Poison Knives, it should not increase the effect of Agonizing Poison from mastery, and math seems ok with 3% (3/3 Poison Knives)
If Agonizing is 3.52 then it should be something like this: 3.52*1.74*1.2*1.03*1.03=7.797 ~ 7.8 like in the guy's video.

Still current formula is using 12% insted of 3% for Poison Knives and needs to be fixed. :)

As for the tooltip, it is using 15% instead of 3% for Master Alchemist and 12% insted of 3% for Poison Knives.

[Quicksand]

Managed to fix the tooltip too

Fixed all calculations, let me know how does it look: https://youtube.com/watch?v=s2fA8ryKqoM: