[FIXED] [Rogue]Death from above vs out of the reach

[N0th1ngArk]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=152150&&name=death-from-above
Bug description: If the player is in mid air during death from above and the target goes out of the reach you deal no damage with the second part of the ability or worse will be thrown under the map if the target goes underground through texture, tested during EN raid at dragons of nightmare and ursoc when the bosses went underground partially with their hitboxes.
Proof: Easily testable, also https://imgur.com/a/gq3Dt from maw of souls when used on any of the mobs from helya

[frenzellinio88]

UP...Agree.

[Cartmon1337]

It can also put you under the textures if used on Serpentrix or the blue/red heads he summons or if used on Wrath of Azshara.

[N0th1ngArk]

I also did some additional tests and sometimes if the target is moving, DFA doesn't follow with the second part which can be a pain in pvp.

[Jugg]

and u forgot to tell, it misses 80% of the times, if target moves just 1 cm dont deal dmg, and u get a CD if u want to see it works, u have to be hitting a dummy or somthing ... it need a real fix since its a really good AOE skill for cleaning m0 and m+

[Quicksand]

Referenced topic: https://forum.wow-freakz.com/Rogue-All-Spec-Talent-Death-from-Above-t475204.html

So as a recap of what did I do:
1. DFA will no longer jump directly to your target, but rather will make the following decisions when choosing the land position:
- if you are within melee range (aka inside of the target's hitbox/selection circle), it will no longer move you at all
- if you are outside of the target's hitbox, it will move you to the closes point on the selection circle.
This means that when used on Helya, Krosus, whoever, it won't make you jump out of the map (also, you should no longer be able to fall under the map in any cases). See video for better understanding
2. DFA will no longer check for range. Regardless of how far are you from the target, when you cast Envenom/Run Through/Eviscerate, it will ALWAYS be in range, aka hit.
3. DFA will no longer check for facing. Even if you show your back on purpose (but 99% of the cases is when your target moves around, especially with high speed), it will still hit the target. Combine with the previous point: the damage will always land.
4. Sidenote, not really important, but DFA will now always automatically rotate mid-air (while coming down) your character towards your target (more natural feel/look).
5. Mentioned in the linked topic: sometimes DFA would cast too fast the finisher (while you were still in the air), resulting in some weird walking down from the air movement. The timing of the finisher now scales properly with the length of the jump, so it should not cast it prematurely.

A quick video on how it looks:
https://youtube.com/watch?v=QhiXdDpJaUs: