Patched version of WeakAuras 2 for 7.3.5

[Artenuvielle]

I just noticed that the version of WeakAuras 2 available in the addon database is a bit odd. It is stated to be a 'CustomFreakz' version and originates from the newest BFA Version (2.16.3). I was not sure how stable this will run. Therefore I took the original latest WeakAuras 2 version for 7.3.5 (2.5.12-15) and added a small patch. I added support for importing the newly compressed strings from wago.io aswell.

If anyone want to have a look into it, you can find it here: https://www.mediafire.com/file/6vybepbr2cynymw/WeakAuras-2.5.12-patched.zip/file

[Anabolic]

It is a backported 8.3.5 version and it works perfectly with our 7.3.5,but ye thanks for effort for making another version working well.

[kotovi]

it doesn't work perfectly , i couldn't get Void Bolt to work on your custom version , im sure there will be more minor bugs like it

[Artenuvielle]

@kotovi Do you mean that the frekz custom version does not work or mine?

[k0s]

Artenuvielle wrote:

I just noticed that the version of WeakAuras 2 available in the addon database is a bit odd. It is stated to be a 'CustomFreakz' version and originates from the newest BFA Version (2.16.3). I was not sure how stable this will run. Therefore I took the original latest WeakAuras 2 version for 7.3.5 (2.5.12-15) and added a small patch. I added support for importing the newly compressed strings from wago.io aswell. If anyone want to have a look into it, you can find it here: https://www.mediafire.com/file/6vybepbr2cynymw/WeakAuras-2.5.12-patched.zip/file

We cannot allow any custom/patched addons files unless you give us a github link to your project and the code you have modified.

[Artenuvielle]

I do not have a Github project for this small change but you can check the diff yourself. The original version can be found here:

https://www.wowace.com/projects/weakauras-2/files/2580604

In there are the following changes:

* Some leftovers from a previous versions (I just copied the new WA2 version into previous versions, then patched and packaged it. Sow now in the first file I posted there was a lot of unused localization files and old changelogs. Here is a new version which is just the original 2.5.12-15 version with the patch: https://www.mediafire.com/file/dhfrid9r7l04oft/2.5.12-patched.zip/file).
* added LibDeflate.lua to WeakAuras\Libs\LibDeflate\...
* Included loading LibDeflate in WeakAuras\embeds.xml (added line 21: <Script file="Libs\LibDeflate\LibDeflate.lua"/>)
* Changed WeakAuras\Transmission.lua: added loading of LibDeflate (line 353) and changed the StringToTable function stating at line 442 (image with diff: https://www.mediafire.com/view/47fmtuwfprbswn0/diff.JPG/file ; diff is reversed in there - red is what I added, green is what i removed when patching)

[Arek75]

I set up a github for this, starting by manually importing the correct commit from the WA2 upstream github (without directly forking it) doing a bit of maintenance to the provided README.md (mostly to keep people from going and pestering the WA2 devs about this), and then applying Arteunveille's changes on top of it. The comparison diff is now available at https://github.com/Arek75/WeakAuras2-freakz/compare/dd30774...6be21ee for those interested (note: you have to copy/paste the full URL, this forum doesn't allow URL tags and doesn't properly parse URLs with extra dots in them). I specifically didn't include my own maintenance in the diff, but you can easily look at my commits and see that I did nothing but add needed libraries (which aren't included in the upstream github) directly from the upstream-released .zip file, and did some edits to the readme. I'm sure there are more edits I could make to make it clear that this version of WA2 is unsupported upstream, but I'm not sure how much effort I should put into that - hopefully the folks that play here know better than to pester the develpers of retail addons about old versions for private servers.

--Arek75

P.S. I hope this is OK with you, Artenuvielle, but I decided to not ask permission and simply exercise my rights under the GPL to do this, in order to hopefully get this version of WA2 added to the Freakz addon list, as it's apparently less buggy than the backported version.

[k0s]

Existing WA are not shown.

[Arek75]

Ok, I just tested this and it does work for me. Imported a string from wago.io, and then completely restarted WoW and it's still listed.

That said, I can see why it might not appear to be working for someone who used the backported version of WA2: Because this version is a lower version than the other one, it is NOT a drop-in replacement for it, and probably won't load your saved aruas (I hope it didn't clobber them or that you backed them up before trying it) - you'll have to either re-import/rebuild your auras in this version, or keep using the backport. For custom auras, you could try exporting your strings from the backport and importing them in this version, but there's no guarantee it will work (imo, it's a longshot at best).

Here are my recommendations:
- If the backport does everything you need it to do and you have custom auras, keep using it unless you feel like re-building your auras. As stated above there's a chance you could export/import them, but imo it's pretty slim.
- If the backport doesn't do everything you need, try this version instead and see if it works.
- If the backport seems to work for you and you're using auras imported from elsewhere, it's up to you, but if you have the time to re-import your strings, you should probably switch to this version, since it's designed for 7.3.5.

As for the addons archive...I doubt it would hurt anything to keep both verisons there, just make sure people are aware which is which.

--Arek75