[FIXED] Base crit problem

[Don.LukyaNo]

WoW Freakz spell link:
Character name:Donlukyano & Prometheus
Bug description: There seems to be a big problem with base crit chance for melees overall.So i have tested a few specs with no items equiped whatsoever multiple times and the crit chance for me is around 1% with 5% on warrior respectively 6% base crit chance on dk (belf racial).I felt the crit % problem has to be somewhere else and i think i found something.
Proof: https://imgur.com/a/CGy6QFO This is warrior fury. I deliberately used specs with 2 fast autoatacks to analyse better the crit rate.
https://imgur.com/a/DM4bdHu This is frost death knight crits.I used one killing machine by mystake so it should be 0 crits on obliterates.
As you can see the base crit is almost non existent on warrior and frost dk.I have like 1% overall crits for 10 minutes of dummy hitting.Of course i can't test all the specs in this game so i would like other people who feel their base crit does waaay less crits than it should to show more tests about other specs.Again ths is naked testing i dont have any crit boosts even with warmode on i got some useless traits so no worry.
Update:I tested more aoe stuff and: https://imgur.com/a/2lfQPwK From what i see the melee classes with 5% crit chance do around 1% crits and specs like enhancement,feral,dh with 10% 11% crit base chance do around 5-6% crits which means there is always this 4% gap in base crit chance and actual crits landed.
Again this is naked gear testing no proc chances or other stuff with 5% crit chance and i do less than 1% crits overall so please don't bombard me with brain dead comments like "It's RNG BRO GIT GUD" because it does not work fine at all.

[Iplayferal]

https://i.imgur.com/d0zkuZC.jpg
https://i.imgur.com/apVYREI.jpg

[Durotar]

https://forum.wow-freakz.com/view-post-6009320.html
you can see that i'm missing 5% crits on my spells
but my auto attack crits seem OK

[florinflo99]

Same here

https://imgur.com/gallery/oO18Riv

[kood650]

Rejected and duplicated :

https://forum.wow-freakz.com/REJECTED-Auto-attacks-critical-chance-5-ingame-lower-than-it-should-be-t597619.html
https://forum.wow-freakz.com/REJECTED-Game-Mechanic-Physical-vs-Magic-damage-t597645.html

https://imgur.com/a/2dwhxYt

Now i am also of the opinion of that there is something affecting crit chance on physical damage, but it might just be a "conspiracy"
If we assume that critical chance follows a binomial distribution (every instance is independent of the last) and you start doing tests for a large sample size, you will see that you get highly unluckly crits xD

https://stattrek.com/online-calculator/binomial.aspx

[Don.LukyaNo]

kood650 wrote:

Rejected and duplicated : https://forum.wow-freakz.com/REJECTED-Auto-attacks-critical-chance-5-ingame-lower-than-it-should-be-t597619.html https://forum.wow-freakz.com/REJECTED-Game-Mechanic-Physical-vs-Magic-damage-t597645.html https://imgur.com/a/2dwhxYt Now i am also of the opinion of that there is something affecting crit chance on physical damage, but it might just be a "conspiracy" If we assume that critical chance follows a binomial distribution (every instance is independent of the last) and you start doing tests for a large sample size, you will see that you get highly unluckly crits xD https://stattrek.com/online-calculator/binomial.aspx

How is it a conspiracy when i do 1500 attacks and i get 10 crits overall
People need to stop testing full geared buffed and azerite affected characters because the problem is not there.The problem is in the base crit and that's it.Melees for example have around 4% less base crit than it should.5% becomes 1% and 10% becomes 5-6% simple as that.smacked the dummy all day on 10 characters and the exact percent i got everytime.
These posts are invalid as the people said with level 10 characters.That's not proper testing that's lazy.

[kood650]

Dude, im not saying you are wrong, as you can see i have the same opinion but in the words of the mods:

This report is legit conspiracy theory crafting but im gonna break it down for you anyways :

First of all, crit chance is something that works same for everything regardless of spell school or something being a spell or trinket spell or melee etc etc and it has a reduced CD modifier in PvP and once again it works the same for everything unless certain class has its own modifier.



Third thing is just because your crit is for example 30% that doesn't mean all your spells will do 30% crit some of them will be at 15% or something, thats just how it is (depends the amount of hits). Because the closer you are to infinity in terms of hits the closer you are to your crit percentage.

And finally here is a proof of physical damage crit chance and azerite crit too properly tested on working dummy and like i said this proof isn't needed since crit works the same way for everything and if it works for one thing there is no reason to assume it doesn't work for a different thing since it is the same script but anyways for the sake of resolving the topic.

CC Value

Melee Hits CC

Trinket Physical proc CC

Melee CC of a pet summoned by trinket

Azerite spell CC And this is pretty much it a lot of different types of CC examples , same crit script and works on same principle and ofcourse approx close to my crit chance and this should pretty much proove that you are wrong.

and btw in the imgur that i posted, i was not wearing any trinket or azerite gear which gave temporary crit chance.
But you can still see in my previous report naked test on critical chance

[florinflo99]

Do you realize that doesn`t matter how bad rng you have for a moment, it will get stable at some point and you can see it in my recount timer, 55minutes with 2500mele hits, we all tested it with mele atack because it is the most relevant thing to test.

[kood650]

I repeat...I Also Agree... i do not think you are wrong, im just informing you of the response i obtain when i last report this issue.
And even if you discard the "low level char" data you still have this.. : https://imgur.com/a/rLJLOa8
Multiple tests, naked and with gear for a large sample data.
try to plug those values in the calculator i sent and see the distribute probability of having around those values

[Don.LukyaNo]

kood650 wrote:

I repeat...I Also Agree... i do not think you are wrong, im just informing you of the response i obtain when i last report this issue. And even if you discard the "low level char" data you still have this.. : https://imgur.com/a/rLJLOa8 Multiple tests, naked and with gear for a large sample data. try to plug those values in the calculator i sent and see the distribute probability of having around those values

21% out of 25%.If you read what i said above you would know that i said that melees are lacking around 4% base crit so thats why the numbers are not quite right.

Update @ 18-03-2021, 20:30:06

Don.LukyaNo wrote:

kood650 wrote: I repeat...I Also Agree... i do not think you are wrong, im just informing you of the response i obtain when i last report this issue. And even if you discard the "low level char" data you still have this.. : https://imgur.com/a/rLJLOa8 Multiple tests, naked and with gear for a large sample data. try to plug those values in the calculator i sent and see the distribute probability of having around those values 21% out of 25%.If you read what i said above you would know that i said that melees are lacking around 4% base crit so thats why the numbers are not quite right.

I dont care about geared crit i only made this post to prove base crit is bugged and i hope people stick with posting about that and only that and not bringing up rejected posts and whatnot that had a different basis as a whole.

[kood650]

"I repeat...I Also Agree..."
And you can find a naked test in those links which also proves your point

Update @ 18-03-2021, 20:42:36

Oh and btw if you have time and a lvl120 caster try to test auto attack crit vs spell crit with something like frostbolt, i would be interested in seeing the results
Thank you <3

[Anabolic]

I think i managed to find what the problem is here.
You can see the data i got from previous topic about this that it was working fine and in the meantime there was a change related to crit chance that was ported to live that bugged the crit for all Melees so you couldn't crit even with 100% which was resolved soon after, but after that now when i run a bot in game and compare to simcraft Crit chance for melee differs from my results few months ago and is always off by 4%.

Proof of crit suppresion removal in Legion image
Link to Blizzard Post


So lets get through the data and why i think this might be the issue. So there was Crit suppression Pre Legion which would suppress your crit 3%-6% and since the crit from my tests that my bot was running on PTR was always exactly 4% lower I assume this might be the only logical explanation because the crit should always equal out to yours the closer you get to infinity (ofcourse you can notice it in 100s or 1000s).

The tests were done the same way as last time ran by bot that was spamming haste increases so they get finished sooner and the difference can be seen that this time no matter how long it runs it never reaches the crit chance compared to last time in my last post. Also both ingame and in simcraft the target was 120 level(matching the player)

Results V1 Paladin (10k hits) ran by Bot ingame
Result V2 Paladin (Matching Simcraft)
Results V3 Death Knight(10k)
Results V4 DK ( Matching Simcraft)

VS

Simcraft Maximum duration Sim Paladin without any buffs same as ingame
Simcraft Half duration Sim DK without any buffs matching ingame

So now when we compare these results they are very different from what i posted few months ago and we can clearly see it doesn't work as intended anymore after the fix that was done recently, unless some form of crit suppresion exists in BFA that I am not aware of.
I will forward this to DEVS and hopefully if it is bugged it will get fixed ASAP if not explanation will be posted here.

Confirmed. Trello Card.

[k0s]

Fixed