[FIXED] [Death Knight] [Unholy] Tak'theritrix's Shoulderpads and Dark Arbiter interaction

[Ligma]

Just a quick recap of what has been discovered while you were away.

1) T20 2p shouldnt affect dark arbiter.

2) Legendary shoulders should work in the following way: Firstly, her base damage on the ability (whatever it is called) gets increased by 40%, then the 1% damage increase per 1 runic power spent component becomes 1.4% per 1 runic power spent because of the 40% increase.

Quote:

Legendary Recommendations: Tak’theritrix’s Shoulderpads (Keystone): These Shoulders add a considerable amount of power to your Arbiter, and are applied to the calculation of Arbiter’s base damage. When combined with the additive damage bonuses from spending Runic Power, this bonus increases their value by the 40% mentioned, allowing you to surpass your Runic Power limitations. (The short version: Using the Shoulders makes Arbiter behave as if each point of Runic Power spent is worth 1.4% damage, instead of 1%)

Source: https://veissdrachen.wordpress.com/2017/06/29/unholy-death-knight-guide/

[Quicksand]

Okay, so the breakdown looks like this: https://imgur.com/a/csxA2Ho

I have 16077 Attack Power, DA inherits 100% of the player's AP, so it also has 16077.

Val'kyr Strike has 220% AP based damage, that makes is: 16077 * 2.2 = 35369
Now, we add 5% from https://www.wow-freakz.com/spells.php?spell=214906 and 10% from https://www.wow-freakz.com/spells.php?spell=241050
That makes it 35369*1.05*1.1 = 40851.195

Now we add 5% from https://www.wow-freakz.com/spells.php?spell=137007&&name=unholy-death-knight (passive effect, it has 5% pet damage buff), so the total is: 40851.195 * 1.05 = 42893.75475

Mastery: 32.33% => 42893.75475 * 1.3233 = 56761.30566

20% from Shadow Empowerment (as seen in the picture; this is the damage bonus per runic power spent): 56761.30566 * 1.2 = 68113.566
40% from Tak'theritrix: 68113.566 * 1.4 = 95358.9935

Actual damage done was 95117. The difference is due to the code not always calculating with decimals, but the actual damage output does not really differ.

Please let me know based on these calculations what should be different, or where the error is :)

Update @ 10-04-2019, 01:51:56

T20 2p cannot affect pets. Blizzard uses a separate Aura Effect (seen in https://www.wow-freakz.com/spells.php?spell=214906 or https://www.wow-freakz.com/spells.php?spell=241050 ) called "Mod Summons Damage %" which affects all summoned units controlled by the player.
VS the T20 2p bonus: https://www.wow-freakz.com/spells.php?spell=246995&&name=master-of-ghouls

It is clear as the sky that the set bonus should only affect the player's output and not the pet's. This was never something I considered as a possibility/bug.

[Ligma]

@quicksand

Well there is your problem. Death coil costs 45 runic power yet shadow empowerment grants only 20% damage? it is a 1 to 1 ratio without shoulders. With shoulders it becomes 1.4% per 1 runic power spent.

Simple version: Shoulders increase val'kyr strike damage by 40%, and also increase the ratio of damage increase per runic power spent. So each death coil cast with shoulders equipped will empower the dark arbiter by 63% instead of 45%.

[Quicksand]

I reeeeeeaaaaally doubt that. Simc does not mention anything of sorts. That would mean you're basically double dipping on taktheritrix...

I'll have a look at some logs from retail

[Ligma]

Go ahead and check logs, the damage difference is very noticeable and with the way dark arbiter functions currently here, those numbers are unreachable.

I mean just take this one for example

https://www.warcraftlogs.com/reports/bjQnzhD3mNWLZCKT#fight=3&&type=damage-done&&source=20

7.2mil max crit on valk strike, you'll never hit that number with the way it works here atm and its goroth there are no additional boss mechanics that give damage increases.

That guy has 939 ilvl

[Quicksand]

https://pastebin.com/raw/KVP1kXFY

Here you go. I simmed a T20 DK with the shoulders lego. The paste above contains only actions from the DA, and i went only with a couple of casts of Val'kyr strikes. I'll give a detailed analyze on this:

First cast

Spoiler:

6.769 Death_Knight_Unholy_T20H_valkyr_battlemaiden valkyr_strike Fluffy_Pillow: snapshot_flags={ AP|CRIT|VERS|MUL_DA|MUL_PER|MUL_PET|TGT_CRIT|TGT_MUL_DA } update_flags={ AP|CRIT|VERS|MUL_DA|MUL_PET|TGT_CRIT|TGT_MUL_DA|TGT_MUL_TA } result=hit type=direct_damage proc_type=HarmfulSpell exec_proc_type=Impact impact_proc_type=HitAmount n_targets=1 chain_target=0 original_x=0 original_y=0 raw_amount=447453 total_amount=447453 mitigated_amount=447453 absorbed_amount=447453 actual_amount=447453 only_blocked_damage=0 self_absorbed_damage=0 ap=57690 sp=0 haste=0 crit=0.2166 tgt_crit=0 versatility=1.084 da_mul=1.4 ta_mul=1 per_mul=1 pet_mul=2.323 tgt_da_mul=1 tgt_ta_mul=1 tgt_mitg_da_mul=1 tgt_mitg_ta_mul=1 target_armor=0
6.769 Death_Knight_Unholy_T20H_valkyr_battlemaiden valkyr_strike hits Fluffy_Pillow for 447453 shadow damage (hit)

AP = 57690 => this is the attack power
versatility = 1.084
da_mul = DamageAmplify multiplier = 1.4 => the lego shoulders (at this point there is no Shadow Empowerment, it is the first cast after summon)
Pet_mul = 1.1 (Fleshsearer) * 1.05 (Cunning of the Ebon Blade) * 1.05 (UH dk passive) * 1.9151 (91.51% mastery: https://imgur.com/a/yjjS6Va) = 2.323

Actual damage = 57690 * 2.2 * 1.4 * 2.323 * 1.084 = 447434

Between first and second cast:
7.272 Death_Knight_Unholy_T20H_valkyr_battlemaiden gains shadow_empowerment_1 ( value=0.45 )

Second cast:

Spoiler:

8.092 Death_Knight_Unholy_T20H_valkyr_battlemaiden valkyr_strike Fluffy_Pillow: snapshot_flags={ AP|CRIT|VERS|MUL_DA|MUL_PER|MUL_PET|TGT_CRIT|TGT_MUL_DA } update_flags={ AP|CRIT|VERS|MUL_DA|MUL_PET|TGT_CRIT|TGT_MUL_DA|TGT_MUL_TA } result=hit type=direct_damage proc_type=HarmfulSpell exec_proc_type=Impact impact_proc_type=HitAmount n_targets=1 chain_target=0 original_x=0 original_y=0 raw_amount=648807 total_amount=648807 mitigated_amount=648807 absorbed_amount=648807 actual_amount=648807 only_blocked_damage=0 self_absorbed_damage=0 ap=57690 sp=0 haste=0 crit=0.2166 tgt_crit=0 versatility=1.084 da_mul=2.03 ta_mul=1 per_mul=1 pet_mul=2.323 tgt_da_mul=1 tgt_ta_mul=1 tgt_mitg_da_mul=1 tgt_mitg_ta_mul=1 target_armor=0
8.092 Death_Knight_Unholy_T20H_valkyr_battlemaiden valkyr_strike hits Fluffy_Pillow for 648807 shadow damage (hit)

Same as above, only thing that changes is da_mul, which is now:
da_mul = 1.4 (shoulders) * 1.45 (45% from death coil) = 2.03
Final damage: 57690 * 2.03 * 2.323 * 2.2 * 1.084 = 648780.

First cast damage was 447434, add the 45% from DC => 447434*1.45 = 648779

You can go ahead and check every single cast, but this one already proves me right. The 45% increase per DC DOES NOT in any case benefit from the shoulders. And before you say that "maybe simc is wrong and it's not possible to hit that much", here you go: https://imgur.com/a/N5mVHuI
Those are final stats for the DA.

No actual source confirms your theory of double dipping on the 40% from the shoulders. So please find another issue, because I am not willing to change something that big based on a shady interpretation of a guide that was written by one person.

[Ligma]

Well, can you replicate those dark arbiter numbers from warcraftlogs on this server? Dont get me wrong im not some dk main trying to get a godlike class, you know i play a mage, but the difference is huge and frankly we are running out of possible reasons why the damage is much lower here than on retail when legendary shoulders are used.

This is probably the last possible reason for the disparity between damage numbers. Thoughts? Maybe it has something to do with this?
https://forum.wow-freakz.com/Death-Knight-Unholy-Sudden-Doom-and-Unholy-Frenzy-talent-t556237.html

Apparently there was a hotfix in 2016-08-08 that made unholy frenzy's attack speed increase also make sudden doom proc faster (like an exception to the RPPM rule where its only increase by haste rating or haste% buffs) but also made sudden doom proc 20% slower, whatever that means.

If its not that either then im completely out of ideas.

At least try some mental gymnastics on how dks on retail were able to achieve such high damage val'kyr strikes like on that retail log i gave you, he was only 939 but managed 7.2 million val'kyr strike crit, maybe you can figure something out.

@quicksand

[Quicksand]

And here you go: https://imgur.com/a/s0ann97

I replicated the same stats on my character on our server: 56790 AP, 8.4% versa, 91.51% mastery.

Check my combat log. It hits for 446151 (vs 447434 on simc, a tiny bit less because of decimal loss)

Then I cast a Death Coil, it gets 45% increase.

It goes to 646919 (vs 648780 on simc).

I don't know what do you expect from me sincerely.

Update @ 10-04-2019, 03:15:31

The only thing I can see that MAYBE influences damage (not checked yet) is the fact that sudden doom procs (or other modifiers that reduce RP cost) should still proc Shadow Empowerment with the full cost of the spell.

Update @ 10-04-2019, 03:22:13

I got to 3.4M non-crit with optimal raid buffs + bloodlust. That would've been around 6.8M crit on our server. Pair that with a concordance proc (which I do not have) and/or a mastery proc, you're easily looking at 7m+ crits. I will try to recreate it in a legit way, will keep you posted.

[Ligma]

Sure thing, also sudden doom free death coils definitely contributed to shadow empowerment. That bit of info kept popping up everywhere.

Maybe we can finally get this shit sorted so the whole server can move on >.>

[CyberKing]

Okay here I am, was asleep thankfully. So I want to ask you how many DC casts you had in that DPS test. Since 57k STR is not a small number. For what you see on Logs, the Str that is in summary is affected by the Potion of Prolonged Power. https://www.warcraftlogs.com/reports/bjQnzhD3mNWLZCKT#fight=3&&type=summary&&source=20 Which makes this guys 50985 Str much less than yours and he does much higher numbers, but I cant say for sure because you have not stated how many DC casts you had in the DPS test. This guy had 13. Could be 12 but I believe from what Ive calculated its 13 from just the durations alone.

"The optimist thinks this is the best of all possible worlds. The pessimist fears it is true."

[Quicksand]

Prolonged Power/concordance, fallen crusader, these all affect your str. I will check how many DC casts you need for a 7m+ crit.

[CyberKing]

No I meant that he has 51k str with Pot up. So his base is like 9k lower than yours and he pulls 7.2 mil crits on 13 DC casts.

"The optimist thinks this is the best of all possible worlds. The pessimist fears it is true."

[Quicksand]

Umm, he has 51k BASE STR.

When he crit for 7.2m he had tons of buffs up: https://www.warcraftlogs.com/reports/bjQnzhD3mNWLZCKT#fight=3&&type=damage-done&&source=20&&by=source&&ability=-207349&&view=events

15% str from unholy str
6100 STR from concordance
2243 AP from Blood Fury
2500 STR from prolonged...

So he had 50,985 + ( 6100 + 2500 ) * 1.15 + 2243 = 63118 STR/AP

[CyberKing]

No he prepotted. Prepot goes into that base Str because it is your Str before going into combat.

"The optimist thinks this is the best of all possible worlds. The pessimist fears it is true."

[Quicksand]

Okay, then he "only" had 50985 + (6100) * 1.15 + 2243 = 60243 STR/AP. Still way above that 57k I had in sims...