[FIXED] [monk][Mistweaver artifact] Sheilun's Gift vs combat

[raven3]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=205406 (wowhead link)
Bug description: So the spell works like this :
while in combat, every 10 seconds you gain a stack of clouds of mist. The spell consumes the stacks to heal a target.
So.. the bug is with the stacks generation. They bug out if you leave combat.
For example:
I duel someone and enter combat. The stacks start to rank up .. 1 every 10 seconds.
So let's say that at 5 stacks I move away and leave combat while still in the duel. If I move back and re enter combat I will be stuck at 5 stacks.
That's not right. - after I reenter combat I should restart where I left of in terms of stack regeneration .. stack 6 , 7 etc
Same happens vs a target dummy.

[Quicksand]

The stacks have individual timer, all of them expire after 1 minute of gaining them. so this might cause it (if you leave at 5 stacks, the first stacks is about to expire in ten seconds, theoretically speaking you can never go above 5 stacks even if you don't leave combat.)

Will check it soon (thinking about making it refresh the duration of the other stacks on each tick, so basically they'd all expire at once, after 1 minute out of combat)

[raven3]

Hmm.. I reentered combat after let's say 10 seconds.
Are you sure they expire?
As far as I know... looking trough posts on official sites.. the stacks rank up to 12 stacks.. and they never expire.. unless you change instances.

[Quicksand]

Not talking about blizzard's implementation, I know for a fact, that each "cloud" has a 1 minute duration FOR US. I know how does it work on retail, since I main monk, I will fix it. Just thought I'd tell you

[raven3]

ooh..ok
thanks for clarifying

[Quicksand]

Okay, not sure if entirely blizzlike or not, but each time a new shroud is summoned, all the current ones reset their timers to 2 minutes. meaning: if you exit combat and stay out of it for 2 minutes, the shrouds will disappear. anytime during that 2 minute window if you re-enter combat, all the active shrouds will be refreshed to 2 minutes again, so you should no longer have any issues with this