[FIXED] [Rogue][Subtlety - pvp talent] Shadow's caress

[raven3]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=209427 (wowhead link)
Bug description: This spell behaves weird.
Every time it procs it resets the cd to max time for my spells that are on cd..
meaning :
I have 2 min cd on vanish and 1.5 min on cloack of shadows.
I use those and I get them on cd. 2 min and respectively 1.5 min until I can use them again.
I wait 1 min so 1 min until I can use vanish and 30 sec until I can use cloack.
And I pop shadowdance so I get the shadow caress buff.
In that moment the wait time for those spells jumps to maximum - 2min and 1.5 min respectively.

I think this spell is also responsible for
https://forum.wow-freakz.com/Rogue-subtelty-pvp-vanish-bug-t490140.html
and
https://forum.wow-freakz.com/Rogue-subtelty-another-pvp-shadow-dance-vanish-bug-t490143.html

[blackshiinobi]

i agree with this guy, when i didn't have Shadow's caress vanish didn't trigger when i used sprint in stealth

[Quicksand]

I have spent around 2 days rewriting the whole cooldown system, managed to uncover a lot of stuff on these recovery rate modifiers

I also managed to fix them normally (now you won't see the cooldown jumping up and down, but rather the recharge rate will become visible higher/lower).
Category spells (those that share cooldown with other spells from the same category - like Vanish, Ice Barrier, Feral Spirits, etc) will still jump up and down, but it was the exact case in 7.1.5 on retail as well ( Proof )
Also, now that things are properly implemented, you can always track your cooldowns if you are interested.

For normal spells (with no category or charges):
/script _,cd,_,rate=GetSpellCooldown(<SpellID>); print("ActualCooldown: "..cd.." | Rate: "..ceil(100/rate).."%");

For charged spells (such as Judgment, Crusader Strike while having Avenging Crusader):
/script _,_,_,cd,rate=GetSpellCharges(<SpellID>); print("ActualCooldown: "..cd.." | Rate: "..ceil(100/rate).."%");

You can put these into a macro, and play around with them, you will need to put an actual spell id for those functions to work.

IMPORTANT: As you know, fixes were disabled for a while, so none of what I said will actually work until we re-enable the fixes. I will mark this topic as "fixed" only then