[FIXED] [Hunter][Beast Mastery] Pet double attack

[BeastMaster]

WoW Freakz spell link: https://www.askmrrobot.com/wow/theory/mechanic/spell/direfrenzy?spec=HunterBeastMastery&version=7_1_5_23420
Bug description: The interaction between the pet attacks and Dire Frenzy is really out of hand since the fixes for the pet haste, which were made 3 months ago.
Proof: It could also be affected and multiplied from this fix: https://forum.wow-freakz.com/FIXED-Multiple-Guardians-vs-Bloodlust-Heroism-t517226.html

With 901 ilvl(shoulders + belt as legendary), on a 3 min and 40 seconds Mythic Trilliax fight, the following hunter from the screenshot had the following number of 488 pet melee attacks: https://i.imgur.com/wAP5iS9.jpg

If we take a look on retail at the top two BM hunters in the world on Trilliax, we will see:

Top 1 worldwide 910 ilvl, 4 min and 3 seconds Mythic Trilliax fight, with a number of 270 pet melee attacks: https://i.imgur.com/gS7i4n1.png
Nr 2 worldwide 910 ilvl, 4 min and 25 seconds Mythic Trilliax fight, with a number of 303 pet melee attacks: https://i.imgur.com/oa4h73O.png

Now...the hunter from our server was using Wild Call with the Dire Frenzy build (interesting choice, because no hunter in top 80 world was using Dire Frenzy + Wild call combined, let's just say that they were noobs and the ones from our server are better) This being a screenshot of his build: https://i.imgur.com/yIimCQF.jpg

Let's now try and find hunters with Wild Call + Dire Frenzy build:

Nr 85 worldwide 908 ilvl, 4 min and 48 seconds Mythic Trilliax fight, with a number of 372 pet melee attacks: https://i.imgur.com/ZqLWlvY.png
Nr 105 worldwide 906 ilvl, 4 min and 23 seconds Mythic Trilliax fight, with a number of 295 pet melee attacks: https://i.imgur.com/pEtUYRk.png
Nr 124 worldwide 904 ilvl, 4 min and 41 seconds Mythic Trilliax fight, with a number of 344 pet melee attacks: https://i.imgur.com/b9f80Ss.png


BONUS! On a 6 min and 20 seconds ( https://i.imgur.com/FX8QfZn.jpg ) Mythic Trilliax fight on this server, 834 pet melee attacks: https://i.imgur.com/70dMj7w.jpg

The whole server switched to Beast Mastery after that fix, suddenly. I understand that it's a 2 button spec that encourages autism, but guys, shame on those that rerolled because of bugs.

[Quicksand]

https://www.askmrrobot.com/wow/theory/mechanic/spell/autoattackmainpet?spec=HunterBeastMastery&&version=7_1_5_23420

The attack speed calculation is done exactly like this. Please feel free to make your own calculations, I'll provide proof here soon that all calculations are working as intended.

[BeastMaster]

Then, please, explain to me why are the numbers of pet melee attacks so huge compared with the retail ones? I understand a difference of 50 additional attacks, but here we are talking about hundreds. The hunter from our server was also just some random guy playing Wild Call + Dire Frenzy (a combination that didn't exist on retail, at least on top hunters).
It's understandable that BM is really good on single target bosses like Trilliax, but here the difference of pet melee attacks is just huge. No one said anything about the damage. This topic is related to the number of attacks itself.
People just quit playing their main specs and went BM immediately after the fix to pet haste, which is weird. You know yourself how people are on private servers, they will always go and abuse positively bugged classes until they get fixed because they want to look good on the recount without effort.

[Quicksand]

I am aware that you are not talking about damage, but attackspeed. However I do play hunter on retail as well, and before implementing all those changes I spent a whole lot of time experimenting and understanding how attack speed is handled on retail. Once again, I will provide proofs from both retail and our server in the near future.

[BeastMaster]

Hey, I know that you want to prove me that the melee formula is fine and 100% retail-like. If it's not that, then it's some interaction between DF and the hunter's haste. It could be multiplicative instead of being additive or something else. I didn't exactly blame you, but instead, I pointed out that after that fix, something is super fishy with the number of melee attacks. It's just way too much.


4 min 20 fight retail: 330 attacks. (around 165 attacks per 2 minutes and 10 seconds)
6 min 20 fight Freakz: 840 attacks. (around 280 attacks per 2 minutes and 6.66 seconds)

Look at those numbers, something is just not right here.

[Mazar]

I've done few tests so here are results:
For every test I left my pet dmg dummy for 5 (300s)min.

ASM formula
= 2 / (1 + TotalHaste) / Spiked Collar
if HasBuff(DireFrenzy)
= CooldownSec / (1 + (0.3 + 0.12 * ArtifactTraitRank(BeastMaster)) * BuffStack(DireFrenzy))

formula for 5 min
300/(((2 / (1 + TotalHaste) /Spiked Collar ) / (1 + (0.3 + 0.12 * ArtifactTraitRank(BeastMaster)) * BuffStack(DireFrenzy)))

1)
200% haste.
After 5 min pet did 504 AAs.
According to ASM it was supposed to be 495AAs. 300/(((2 / (1 + 2.0)/1.1) / (1 + (0.3 + 0.12 * 0) * 0)))

Edit: This one seems allright now.

2)
200% haste + 3x frenzy all time up but without trait.
After 5 min pet did 1364 AAs.
According to ASM it was supposed to be 940AAs. 300/(( (2 / (1 + 2.0)/1.1) / (1 + (0.3 + 0.12 * 0) * 3)))

3)
200% haste + 3x frenzy all time up with trait.
After 5 min pet did 1468 AAs.
According to ASM it was supposed to be 1118AAs. 300/(( (2 / (1 + 2.0)/1.1) / (1 + (0.3 + 0.12 *1) * 3)))

Let me know if there are errors in formulas.

Edit: I forgot about Spiked Collar bonus. Now is formula hopefully correct. Right values added.

Dunno what cause that but this seems suspicious:
Behaviour on freakz test reaml:
https://youtube.com/watch?v=ejk2OYy4LeA:


Pet sometimes do dmg twice in 1 AA. Could be visual bug but who knows.

[Quicksand]

If you don't want to bother with calculating the formula all the time, make a macro, and paste this:
/dump UnitAttackSpeed("pet")

It will tell you your pet's attack speed in seconds (0.734 is 734ms or 0.734seconds, pretty obvious). I have to mention however that this macro will only work starting from the next restart, currently it will give you the wrong values, even though they are correctly calculated on the server.
I won't close this report just yet, but I think I figured out why did sometimes the pets attack twice on one autoattack (thus causing the huge difference in number of attacks compared to retail).
But the attackspeed itself was calculated properly, and it's 100% blizz-like. I've spent several hours again comparing results from the macro mentioned above on retail and on our servers (with and without DF, Bloodlust, that trait, etc, all sorts of combinations between trinkets, talents, auras, etc), but I did not find a single situation in which the values were different on our server.

Please provide feedback tomorrow

[Foxed]

You already changed something on live server so we can test?

https://www.freakz.ro/forum/achievement-Unique-a176.html

[Mazar]

Dunno if changes are live but everything seems same.

I've made deeper research and I find out that its not only one bug but two bugs.

First one is Spiked Collar double dipping
Behaviour on freakz test reaml:
https://youtube.com/watch?v=PQlmcrfgtPY:


Attack speed with only Spiked Collar should be 2/1.1 = 1,818181818181818
Atm its almost 2/1.2 = 1,666666666666667 thus double dipping
Edit3: actually its is 2/1.1/1.1 = 1,652892561983471

Attack speed with without Spiked Collar and Dire Frenzy is Blizzlike on every haste level.


Second one is Dire Frenzy causing 2 times faster Attack speed
Behaviour on freakz test reaml:
https://youtube.com/watch?v=ktnpyD_2a34:


Attack speed with only Dire Frenzy 3 stacks (without artifact trait Beast Master) should be 2/1.9 = 1,052631578947368
Atm its almost double (0,5263157894736842)

I've tested Dire Frenzy 3 stacks with trait Beast Master and same result.

Edit: Well for Dire Frenzy with trait Beast Master its more then 2 times faster Attack speed.

Edit2: I realized that Dire Frenzy is calculated twice.
Atm its 2/1.9/1.9 = 0,554016620498615

[Labush]

Due to the fact that there is enough evidence to confirm this bug, I conclude this post to be confirmed. Quicksand will try and solve this as soon as he can. Mazar, Quicksand and BeastMaster, good job on the calculations and proof!

"Misdirect dont confirm posts without having any idea about how the spell work or play hunter . Thx !" -- Gladys 2k18 ( ͡? ͜ʖ ͡?) ( ͡? ͜ʖ ͡?) ( ͡? ͜ʖ ͡?)

[Quicksand]

@Mazar, I cannot reproduce ANY of the things you did there. I have no clue what went wrong, let me know if the issue persists or not, because these are my results:
https://youtube.com/watch?v=41VXIt5S30A:



You probably did the tests before the fix going live, I told you it would give you the wrong values, I have no other explanation. All attackspeeds are calculated perfectly

Update @ 04-06-2018, 21:59:42

Also, the pet double attacks are no longer happening. Test it again please because afaik this works correctly now

[Mazar]

Now everything works correctly/blizzlike. I've tested today every haste/Spiked Collar/Dire Frenzy scenario.

[Quicksand]

Fixed