[FIXED] [Shaman][Enhancement] Stormbringer Proc Chance

[Artenuvielle]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=201845&&name=stormbringer
Bug description: see https://forum.wow-freakz.com/REJECTED-Shaman-Enhancement-Stormbringer-Proc-Chance-t547917.html (Don't know why this gets rejected without giving me the opportunity to provide any logs.)
Proof: Same as in previous post. I logged a fight while only attacking a raiding dummy with auto attacks.

Original log: https://mega.nz/#!ihgUjIBB!hbYsw91UHH4n0a495hm_UhFEFLyhpnzjnVqWkiCRqKc
Cleaned log (removed events with source being not me): https://mega.nz/#!OppGSI5Z!4kKgOCmV0kokC3De2H1YlyO774BOV8xhHDW8XJZKCSU

When you look at the cleaned log you can search for lines containing "Stormbringer". There are exactly 60 occurrences - half of them being the SPELL_AURA_APPLIED events and the other half being the SPELL_AURA_RMOVED events. So 30 procs actually happened. When searching for events with the name SWING_DAMAGE (all of these should be able to proc) you'll find that there were 1201 successful attacks. This results in a proc chance of only 2.49%.

Somehow the isOffHand flag wasn't logged for me (did I miss it somewhere?).
EDIT:

Quote:

I looked at the damage numbers of the auto attacks in detail and offhand hits deal about 25k damage and mainhand hits around 55k damage (doubled of course if the crit param is 1 and not nil). I also looked at all the auto attacks right before any of the procs occurred. All of them were main hand hits (either ~55k damage without crit or 100k+ with crit). So I still think that Stormbringer does not trigger on offhand attacks like it should.

I checked the timings of the Stormbringer procs and compared the closest melee hit log event which is not later than the actual proc. Looking at these, I noticed that some of the procs had to come from offhand attacks. However the overall proc chance is still too low.

[Whysoimba]

I spent 20 minutes and literally watched to see if any offhand attack procs stormbringer and every time it did proc it was after the main hand attack. Now this isn't any proof but it could be worth looking into since it should proc from any attack.

[SourLemon]

Confirmed, proc chance is too low.

[Quicksand]

Some spells and all of your off-hand attacks could not proc stormbringer.

Fixed