[FIXED] [Priest][Discipline] Atonement

[Lhiithium]

WoW Freakz spell link: Atonement
Bug description: Healing transferred through Atonement is too high.
Proof: Let's start by looking at this priest's numbers (minute 9.05). Look at the date, it's not a PTR vid.
So, his base Atonement healing of 40% is increased by 40.1% of his mastery which means 56% healing transferred through Atonement.
Now, let's take a look at the damage and healing of Purge the Wicked here (minute 10.57)

53 323 damage and 21 813 healing
Let's do the math, 56.1/100 * 53 323 = 29 914 > 21 813 (his)

Why is the healing he's doing lower than the math one?
An explanation is given here, a post from the around the same time with the video.
Long story short, if you read from the 6th post below, some damage modifiers on Light's Wrath don't transfer through Atonement.

"Yep. In particular the bonuses that increase Damage AND Healing do not double dip when it comes to atonement transfer."

This is a video of my priest healing through Atonement.
Let's do the math again, 59% healing through Atonement which should be lower because of the above argument and proof.

59/100 * 290 969 = 171 745 < 184 731 (mine)
59/100 * 541 938 = 319 743 < 369 338 (mine)

Not only the heal is not equal with 59%, but bigger, and it should be smaller.
The calculations I've done are rough and not take into consideration Versatility or other modifiers that I don't know about, but regardless, the difference is not small.

[decenu]

Confirmed

[Elvenking]

So reducing the dmg modifier he gets with 51 traits: -25.5% dmg increase passive -5% dmg increase [Forbidden Flame] -10% dmg increase [Will of the Conclave]
it is quite accurate to calculate his healing.

Goal: 53322 > 21813

Math:
-53322 x 0.745 = 39725 x 0.95 = 37738.6 x 0.9 = 33964.78 base dmg
-33964.78 x 0.56.1 = 19054.2 base heal
-19054.2 x 1.05 = 20006.9 x 1.1 = 22007.6 final result

(small derivation as 56.1% mastery could actually be something between 56.05%-56.14%)

So can confirm that artifact dmg modifier should not increase atonement healing.

Here people discuss about this topic too and say that passive weapon dmg did never increase atonement heal:
https://us.battle.net/forums/en/wow/topic/20758447049

Regarding 7.2.5 changes to give disc also 15% more healing like all other healers the dmg increase from these traits does no longer count towards atonement too.
Maybe check a few more videos to 100% confirm this, no time to dig deeper rn.

[Barnacle]

"Essentially this is what is happening. Your damage increase from your artifact doesn't transfer to into healing. You have to do the math, and remove that bonus. Seems kind of silly, but its just how it works *shrug*" from the Blizzard forum.
Elvenking already did the calculations and this seems to be correct.

When I tested it i did:

331899 damage with smite and 200304 healing with my atonement
I have 52.2% Mastery and 4.93% Versatility
331899*.71*.95*.90===201479 "true" damage. what this means is that instead of the 200304 healing the spell is doing right now it should be doing:
201497*.522*1.0493===127462 healing, which in turn seems way too low again.

*edit* I forgot to apply the healing bonus to the 127462 figure, meaning that the healing should be:
127462*1.1*1.05===147219, which is of course a pretty big difference.

*EDIT2*

I've made a spreadsheet with various calculations and using data from a few different youtube videos, what I've concluded from this is that the damage modifiers from all artifact traits should be subtracted from the actual damage done before applying the atonement calcuation, I'm still about 1% off here but I think that is more due to rounding errors and information discrepancy.

Spoiler:

Here's the sheet.

It should be self explanatory

XXX Barney

[Quicksand]

Basically, all "Mod Damage Done %" effects are removed from atonement healing (such as https://www.wow-freakz.com/spells.php?spell=241148)

However, spells that modify specific spell's damage will NOT be reduced (such as discipline priest's passive https://www.wow-freakz.com/spells.php?spell=137032&&name=discipline-priest and all "Add Spell Modifier %" effects)

Fixed.