[REJECTED] [Priest][Shadow] antorus t21 2p

[boky123]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=251845&&name=item-priest-t21-shadow-2p-bonus
Bug description: i feel like the damage increase isnt working as expected; from the tests i managed to do with mind blast (didnt test mind flay yet because its a bit harder to do); i managed to capture 2 hits on same target with same conditions ( no procs etc )

with set it hit for 1.1mil
without set for 920k

that looks something like 22-23% increase , lets round it to 25 for stats change, more versatility, and slight int increase; in my screenshot i have my full stats reported so if someone can do a more precise math i would gladly appreciate it , thanks!

Proof: https://imgur.com/a/nVwX5W0

[Anabolic]

It works correctly and this is why:

If you read the set it says critical strike bonus is increased by 50%,so what does that mean it means crit dmg=crit bonus and only crit bonus is increased so if you look at your proof this is what we have:

Mind Blast: 450833 hit so crit bonus is also 450833 and it is empowered by 50% so 450833x1.5=676 249.5 and that is your crit bonus now.

The math goes on like this from now on 450833+ new crit bonus which is 676249.5 =1 127 082.5 which is the same number as in game.

This is my take on it we will see what Priest CM has to say for this.

[boky123]

okey i thought it would be something like this?

lets take the same example;

if a normal hit is 450833; a normal crit without the set would be 901666, and this gets empowered by 50%, so it would be like 1352499? what you are saying kinda makes sense too but why would it empower just the critical part and not the whole hit is out of my reach , i understand that there could be bonus critical dmg and critical strike bonus dmg? i guess, how does the drape of shame work ? is it that the difference? is what im saying the "critical dmg" increase or i guess healing of it #Confused

[VoidToilet]

What you are asking there is empowering the crit by 50% of the damage dealt.
You can see that the tier set states that the "crit strike BONUS damage" is increased.
It clearly states that it empowers just the crit bonus, not the whole crit strike as a whole.

Think of it like this:
Your normal hits to 100% damage
Your normal crits do 200% damage, so you have a bonus damage of 100% on top of the regular hit
Now the tier says that it increases the "BONUS damage" by 50%
If you add 50% to the 100% bonus you get 150%
So now your crits will deal 250% damage(100% base and 150% bonus)

If the whole strike would get empowered as you are saying there then that would be 300% damage(100% base 200% bonus).
Which is clearly not the case.

And in this way you get that difference of 25% increase (200% * 1.25 = 250%)

So the damage provided by the tier is correct (Spriest main, ofc I would like random buffs but we have to keep it like retail).

[boky123]

oh okey i see, i think i might have miss interpreted it then

[Anabolic]

This is what Quicksand said about this last time he explained it:

Quicksand03/25/2020
i explained it ten million times. crit damage is calculated as such
damage = 100
crit_bonus = damage
AddModifiers(crit_bonus)
damage += crit_bonus
which translates to
lets say you want 6% bonus damage on crits
damage = 100
crit_bonus = 100
crit_bonus = crit_bonus * 1.12 = 112
damage = 100 + 112 = 212
200 * 1.06 = 212

tl;dr crit bonus modifiers apply to HALF the damage, so they are DOUBLE the value

So ye the crit bonus on that set is already Doubled(i think because this is the case for things like Critical Chaos on DH ),and thats why you apply 50% instead of 100% on the spell's crit bonus. I guess at the end its best to leave the final word to DEVS when they have time,but once again im pretty sure the math i posted is correct because it is scripted correctly for other similar cases and i don't se a reason to be wrong here.

[Barnacle]

as anabolic said already, it's only the bonus damage that get's increased.
this works properly.

Rejected

XXX Barney