[FIXED] [Paladin][Holy][Trait] Shock Treatment

[novax]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=200315 (wowhead link)
Bug description: even though the healing of critical holy shock increased with the last update , it still does less healing than it actually should
my normal holy shock does 183k, with 3/3 rank of this trait and double times crit : it should heal 183*2*(1+0.24) = 454k but it is 412k which is wrong
ALSO i asked one of my friends which has 3 relics on this trait (6/6) with 48% increase healing on critical holy shock and find out the extra 3 ranks of those relics dont work at all . its normal holy shock heals 177k and with crit it does 440k healing which should be 177*2*(1+0.48) = 524k
Proof: http://imgur.com/a/fX8y5
http://imgur.com/a/ih035

[Seyrox]

Please bring proof that it should be like you are saying, because I believe it is working fine.



Demonolgy Warlock Guide 5.4.8

[novax]

The calculation above is based on the game tool tips .
We know that critical strike is a chance that does 2x times of the normal Healinh/Damage . with 183k normal holy shock healing , the critical one should heal 2 * 183k = 366k
This trait obviously shows that it increases healing or damage of critical holy shock by 8% per rank.

so with 3 ranks of this trait , the healing/damage done of critical holy shock should be increased by 24% which means : (1+0.24) * critical holy shock healing/damage(366k) = 454k

I did a search on askmrrobot.com about [shock treatment] and find out this trait is an Extra Crit Healing Multiplier type . It says : "These combine differently than regular critical healing multipliers, and the tooltips generally show half of the actual value used." which means the 8% that trait tooltip shows should be 16% (per rank) . you can also check 16% on this http://www.askmrrobot.com/wow/theory/mechanic/spell/shocktreatment?spec=PaladinHoly&&version=7_1_5_23420 ,

[Brigadee]

Oke, so, as you say, holy shock critical formula should be :

Quote:

normal heal * 2 * ( 1 + traits number * 0.08 )

Current formula is:

Quote:

normal heal * ( 2 + traits number * 0.08 )

As you say here :

novax wrote:

i asked one of my friends which has 3 relics on this trait (6/6) with 48% increase healing on critical holy shock and find out the extra 3 ranks of those relics dont work at all . its normal holy shock heals 177k and with crit it does 440k healing

By current formula , 177 * 2.48 = ~440k, so relic works.
Invalid.

Now, about the formula..
I made some research but couldn't find anything atm about the formula based on Shock Treatment (wowhead link)

Shock Treatment says:

shock treatment wrote:

Increases critical strike damage and critical healing of Holy Shock by 8% per trait.

Oke, critical healing without traits is:

critical healing wrote:

critical healing = normal heal * 2 = 200% of normal healing

So , as Shock Treatment (wowhead link) says:

Quote:

Incrases critical healing of Holy Shock by 8% per trait.

That means, for each Shock Treatment (wowhead link) trait, on that 200% of normal healing should be added the procent from Shock Treatment (wowhead link) traits.

By that, leading with 6traits up to 48%, 248% of normal healing, by your friend test:

friend test wrote:

248% of 177k = ~440k , seems legit.

So, by my opinion, it works correctly at this moment, the only way @quicksand would change the formula is that you should bring the exactly formula of holy shock critical strike.

And about :

askmrrobot wrote:

which means the 8% that trait tooltip shows should be 16% (per rank) . you can also check 16% on this http://www.askmrrobot.com/wow/theory/mechanic/spell/shocktreatment?spec=PaladinHoly&&version=7_1_5_23420 ,

8% is the right value found on all blizzard legion tooltips, as mrrobot says, is a Theory , not how the spell should work 100%.
You can check the following post if you dont agree with askmrrobot being wrong on some cases
Rejected Legendary Cloak Pholy
The reply that quicksand did to me made me see that askmrrobot should not be trusted in all cases.

@seyrox


Holy Paladin 7.1.5 Guide

[Quicksand]

Critical Damage/Healing modifiers are not multiplicative, they never were. If you have an aura that increases crit damage by 50% and another one that increases it by 25%, it will give 75% and NOT 87.5% (that you'd get by calculating your way: 1*1.5*1.25).

Thus your calculations are wrong.
In your case, 183k with 24% increase would be 183 * (2 + 0.24) and NOT 183 * 2 * 1.24.

183 * 2.24 = 409k.

I won't close this topic just yet, I need some kind of confirmation from retail, because I am aware that tooltip says 8/16/24 but the actual value is 16/32/48. I forcefully changed the used value to match the one from the tooltip, but as of now I am not really sure why did Blizzard do it that way. Usually they do such thing when they do precision. They cannot give real numbers as values in tooltips, so if they want to have something like 3.5%, they usually give 7% as the value, and make the tooltip show ${s1/2} (so it shows up as 3.5%).
It is very common for Blizz to do things this way, but in this case I wasn't sure either why did they use ${s1/2} in the tooltip, as 8/16/24 are integers, no need for precision. Maybe back in the days it was 7.5%, 15%, 22.5%? I don't really know.

I will need confirmation from someone that has a holy paladin on retail, that the crit damage increase is actually uses 8/16/24 and not 16/32/48

[Elvenking]

It's not a good proof and I will try to search better one:

https://youtube.com/watch?v=pYH_UGLb-TM&t=1445:



I watched this guide for a while from 24:00 to 28:00 and tryed to analyze his non-crit and crit heals with holy shock (he has 3 traits = 24% shown around 15:00).
It's a little hard to see without combat log, but his non-crits where around 180-190k and crits around 450-470k heals.
(testing: look when his holy shock spell gets cd/rdy and confirm crit heals with buff he gets)
Using this numbers we get around 248% increased heal from his crits, so the calculation really seems to be 183*2*1.24.

Maybe for better proof we should analyze more holy pala poe videos from retail or as already mentioned a person who tests it there.

[novax]

Quicksand wrote:

Critical Damage/Healing modifiers are not multiplicative, they never were. If you have an aura that increases crit damage by 50% and another one that increases it by 25%, it will give 75% and NOT 87.5% (that you'd get by calculating your way: 1*1.5*1.25). Thus your calculations are wrong. In your case, 183k with 24% increase would be 183 * (2 + 0.24) and NOT 183 * 2 * 1.24. 183 * 2.24 = 409k. I won't close this topic just yet, I need some kind of confirmation from retail, because I am aware that tooltip says 8/16/24 but the actual value is 16/32/48. I forcefully changed the used value to match the one from the tooltip, but as of now I am not really sure why did Blizzard do it that way. Usually they do such thing when they do precision. They cannot give real numbers as values in tooltips, so if they want to have something like 3.5%, they usually give 7% as the value, and make the tooltip show ${s1/2} (so it shows up as 3.5%). It is very common for Blizz to do things this way, but in this case I wasn't sure either why did they use ${s1/2} in the tooltip, as 8/16/24 are integers, no need for precision. Maybe back in the days it was 7.5%, 15%, 22.5%? I don't really know. I will need confirmation from someone that has a holy paladin on retail, that the crit damage increase is actually uses 8/16/24 and not 16/32/48

askmrrobot.com clearly says that [Shock Treatment] effect is multiplicative and it separates this trait from critical healing modifier type and sort it as Extra Crit Healing modifier . But if u say askmrrobot is not a trusted proof , its another discussion.

[Brigadee]

Well, made a quick look on the video above and seems like:
normal heal : ~190k
critical heal : ~460k
traits number : 3

So here are 2 options:

The formula is the one below, but i dont think so.

formula wrote:

normal heal * 2 * ( 1 + nr traits * 0.08 )

Or, shock traitment traits should give 16% per trait and not 8% says, like quicksand explained above about blizzard tooltips&decisions, with the correct formula being:

formula wrote:

normal heal * ( 2 + nr traits * 0.16 )

Because, by doing math with both formulas, same number occurs.


Holy Paladin 7.1.5 Guide

[Elvenking]

Finally I got a solid proof from retail:



With his combat log we can easily do the math now (3 traits = 24%).

avg. non crit heals = (104k*3+109k)/4 = 105k
avg. crit heals = (253k + 253k + 260k+264k)/4 = 257.5k
(just calculated arithmetic mean with holy shock numbers from that combat log
with the first holy shock crit entry we get exactly 4 crit and 4 non crits)


Now bonus heal from crit = 257.5k / 105k = 2.45...
due to deviation we can say it should end up as ~2.48 if we calculate over a large amount of heals

Now using our Formulars on one of his non crit heals (e.g.: 104k, everything rounded down):

@Brigadee you slipped a decimal place with your formula

formula wrote:

normal heal * 2 * ( 1 + nr traits * 0.08 )

104k * 2 * ( 1 + 3 * 0.08 ) = 257k (seems legit)

formula wrote:

normal heal * ( 2 + nr traits * 0.16 )

104k * ( 2 + 3 * 0.16 ) = 257k (obviously the same)

formula wrote:

normal heal * ( 2 + nr traits * 0.08 )

104k * ( 2 + 3 * 0.08 ) = 232k (too low regarding the range of his 4 crit heals 253-264)


This tells us that Blizzard tricked us with a tooltip again (or wanted it to look like a multiplier)
@Quicksand

[Seyrox]

So the correct formula should be:

Noncrit*2*(1+no. of traits)

What about the 16% increase per trait instead of 8% that was discussed earlier ?



Demonolgy Warlock Guide 5.4.8

[Quicksand]

Well using 16% instead of 8% yields the same results as if you did things multiplicatively, as the crit is 2x.

Reverting my custom fix, server-side calculations will now use 16/32/48/64/80/96 (the original blizzard stuff), so it adds up correctly.