[FIXED] [All] Smart Heal mechanic (incorrect target priority or incorrect targets)

[zeakey]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=115151&&name=renewing-mist
https://www.wow-freakz.com/spells.php?spell=33076&&name=prayer-of-mending
Bug description: Should act as smart heal and not heal statues, portals, monk copies, gates, passive pets (like dk slugs) etc. Basically shouldn't heal anything that isn't a player or an active pet. Prioritising Players first and only then jump on to pets if every other player already has an helpful effect on them.

Demonstration: https://youtube.com/watch?v=E5IWD50ES_Y:



Step 1 - Cast renewing mist
Step 2 - It jumps over to the gate
Step 3 - Gate says it is immune therefore the hot just uselessly disappears.

Proof:
Prayer mending - https://imgur.com/ex1nh0W
Renewing mist - https://imgur.com/fiPb1lH

I am guessing a lot of spells with similar mechanic are just as broken. Since I been simply banned by asking to give me an account on test realm I am guessing it is for you guys to find out what other spells don't works as they should.

[KremX]

All smart heals are affected by this bug.

Beacon of Virtue, Light of Dawn, Wild Growth, Chain Heal, Essence Font, Holy Word: Sanctify, Power Word: Radiance etc.

[Barnacle]

I've posted this in another topic regarding Power Word: Radiance already but I'll paste it here again, since it looks like this is caused by the same bug:

Elvenking wrote:

The spell was scripted as smart heal in 7.1.5 and what i saw it still works like that. Just there are now 5 instead of 3 atonements and somehow the 2 new ones act wierdly in many situations. Probably some mechanics still just use 3 instead of all 5 targets, but that's just an assumption. Maybe you can screen a situation where it bugs as i even recorded a whole raid once and it never happend to me there

Barnacle wrote:

As Elvenking said, only the two last atonements applied behave weirdly, but I want to add to that that this is not consistent and thus extremely hard to test, as there is always a chance your atonement will land on a random player who is injured, while it could've also "picked" another random full health player. The notion that smart heals should only affect random injured players when there are enough of them is correct, but the issue right now is that even full health players will get healed sometimes when you use Radiance. This behaviour is not unique to Power Word: Radiance as some other AOE healing spells have the same problem. Another problem is that warlock pets can sometimes get healed or get atonement aswell even though there are players who should always get it first (not even sure whether aoe heals should ever heal warlock pets).

And from that same topic some proof:

lanstyler wrote:

The random behaviour is noticable in a raid environment: Here are some gifs from NH hc fights, in all three cases I target the boss and cast PW:R on myself. So one atonement gets spread on myself (Grp1-2), all others behave randomly. 1: [img]https://imgur.com/a/gvJRVlq[/img] Injured allies: Grp1-1 (has atonement), Grp3-2, Grp3-4 (has atnonement), Grp3-5 Atonement: Grp1-2, Grp1-3, Grp1-5, Grp2-5, Grp3-3 -> no matches should be: Grp1-2 (because i cast on myself), Grp3-2, Grp3-5 + random -------------- 2: [img]https://imgur.com/a/6nmp5Cn[/img] Injured allies: Grp1-2, Grp3-2, Grp3-3, Grp3-5 Atonement: Grp1-2, Grp1-5, Grp3-1, Grp3-3, Grp4-1 -> only match is myself because i cast PW:R on myself. should be: Grp1-2 (because i cast on myself), Grp3-2, Grp3-3, Grp3-5 + random -------------- 3: [img]https://imgur.com/a/ZmwbYyo[/img] Injured allies: Grp1-2 (has atonement), Grp1-3, Grp1-4, Grp1-5, Grp2-5 (has atonement), Grp3-2, Grp3-4 Atonement: Grp-1-1, Grp1-2, Grp1-3, Grp1-5, Grp2-2 -> I get atonement because i cast it on myself, Grp2-5 doesn't get atnonement because he already has it - thats good; everything else is random should be: Grp1-2 (because i cast on myself) and four of these: Grp1-3, Grp1-4, Grp1-5, Grp2-5, Grp3-2, Grp3-4

I feel like this is one of the reasons Disc is being held back, since atonements on full health targets only help your overhealing.

XXX Barney

[Shocker]

We (me, Krem, Barnacle) all did more research and we decided there are 2 main smart heals categories:
- smart heals which only target players and always heal the "most injured" targets first
- partial smart heals which can also target pets (but DO NOT target temporary guardians/summons [wild imps, demonic gate, etc]), but pet targeting will happen only after all players are at full health already. Also, these partial smart heals won't always heal the "most injured" target first, but a random one from the list of injured targets. There is a third secondary category here, and that's "partial smart heals which only target players" (meaning they only heal players but randomly from the list of injured players)

I think this should sum up all the smart healing system and should be much better now.

P.S.: Knowing exactly which spells should be smart heals, partially smart heals or partially smart heals players only might be a bit tricky (for most you can see from their description), so in case we missed some (or incorrectly assigned some) you need to tell us the EXACT SPELL NAME/ID which should be changed/categorized differently

FREAKZ COMMUNITY @ Facebook
WOW FREAKZ @ Facebook