[REJECTED] [Rogue][Sub] Shadowstrike Modifier missing

[djordjebre96]

WoW Freakz spell link: https://www.wow-freakz.com/spells.php?spell=185438&&name=shadowstrike
Bug description: Damage too low, missing 20% damage modifier from trait.
Proof:
Shadowstrike tooltip naked:
https://imgur.com/a/dc1nW7T (55,842 tooltip)

Formula:
5,173.5 (average weapon damage) * 8.5 (modifier 850%) * 1.27 (sub rog modifier 27%) = 55,842.535‬ (exact amount thats shown on tooltip)

Shadowstrike tooltip with random intellect daggers:
https://imgur.com/a/7absGVJ (47,845 tooltip)

Formula:
4,690.5 (average weapon damage) * 8.5 (modifier 850%) * 1.27 (sub rog modifier 27%) = 50,633.9475‬ (on screenshot you can see that its already lower than this)

Shadowstrike tooltip with artifact weapons:
https://imgur.com/a/OUublt7 (271,993 tooltip)
Artifact trait amplifiers of shadowstrike:
https://imgur.com/a/o6z5LYJ

Formula:
21,436.5‬ (average weapon damage) * 8.5 (modifier 850%) * 1.27 (sub rog modifier 27%) * 1.05 (5% dmg trait) * 1.1 (10% dmg trait) * 1.04 (4% phys dmg trait) * 1.2 (20% shadowstrike dmg trait) = 333,559.3 (should show on tooltip)

(20% damage trait seems that doesnt work, because if you take 20% off this number you get tooltip damage - 333,559.3 / 120 * 100 = 277,966) <---- missing modifier

Actual damage:
https://imgur.com/a/Omk5tkf (shadowstrike from stealth, with bonus 25% damage) (198,649 non crit on average)

If you add back damage that was reduced by dummy armor: 198,649 / 68 * 100 = 292,130.8 and take bonus 25% damage off = 233,704
How much it should have hit:
333,559.3 * 1.25 * 0.68 = 283,525 (which is again 20% difference)

Needless to say, damage difference goes nuts when I actually equip gear.

Stats:
https://imgur.com/a/QZR46hz (589,801 tooltip)

Formula:
42,903‬ (average weapon damage, with versa) * 8.5 (modifier 850%) * 1.27 (sub rog modifier 27%) * 1.05 (5% dmg trait) * 1.1 (10% dmg trait) * 1.04 (4% phys dmg trait) * 1.2 (20% shadowstrike dmg trait) = 667,585 (should be tooltip)

Considering this ability has increased critical strike damage (32% base without relics for the trait), higher numbers = bigger difference.

----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Here's with pvp modifier:
https://imgur.com/a/QLxNQJk (190,395 tooltip)
https://imgur.com/a/rlNOPMs (208,841 non crit on target with no damage reduction, armor or versa)

Math:
190,395 * 1.15 = 218,954.25‬ on average, sometimes lower, sometimes higher
Conclusion for world pvp:
It does damage shown on tooltip, but tooltip is WRONG and modifiers are not applied, it should be 333,559.3 * 0.7 = 233,491.51‬ and then 15% on top of that 233,491.51‬ * 1.15 = 268,515 (damage it should have done on average)

Here's actual example in PvP situation:
https://imgur.com/a/GINExyt (260,181 tooltip)
https://imgur.com/a/2NEcGSJ (282,461 tooltip with concordance up)

In instanced pvp there is no damage variation for balance purposes, damage should always be exactly same, and here's math behind it:
20,085 (weapon damage, with versa) * 8.5 (modifier 850%) * 1.27 (sub rog modifier 27%) * 1.05 (5% dmg trait) * 1.1 (10% dmg trait) * 1.04 (4% phys dmg trait) * 1.2 (20% shadowstrike dmg trait) = 312,529 * 0.7 = 218,770.3‬ (should be)
The number it shows on tooltip is number that you get in the equation above, just exclude last 20%, and you get 260,441 (number on tooltip), and -30% pvp modifier isnt shown on tooltip. 260,441 * 0.7 = 182,308.7 (current one)
So tooltip in instanced pvp is bugged and doesnt show, and 20% dmg trait isnt working still.

It does way less damage even if you calculate things based on it and here's math:

Lets calculate damage based on weapon damage with concordance:
21,805 (weapon damage, with versa) * 8.5 (modifier 850%) * 1.27 (sub rog modifier 27%) * 1.05 (5% dmg trait) * 1.1 (10% dmg trait) * 1.04 (4% phys dmg trait) * 1.2 (20% shadowstrike dmg trait) = 339,293 * 0.7 = 237,505.1 (should be tooltip)

Based on wrong tooltip (current state), during shadow dance and buffed with concordance:
(282,461 (with concordance) * 0.7 = 197,722.7) * 1.3 (Dark Shadow talent) * 1.1 (Symbols of Death) * 1.15 (Nightblade debuff) * 1.05 (Void Elf racial) * 1.82 (additional crit damage from trait) = 621,371 base crits (current state)

Based on my calculation, during shadow dance and buffed with concordance:
237,505.1 (with concordance) * 1.3 (Dark Shadow talent) * 1.1 (Symbols of Death) * 1.15 (Nightblade debuff) * 1.05 (Void Elf racial) * 1.82 (additional crit damage from trait) = 746,392 base crits (should be)

(I know Dark Shadow should be 25% in instanced pvp, but currently its 30% so I calculated it that way.)

Now, regular player on average has about 30-40% flat damage reduction with armor + versatility, which still doesn't bring numbers anywhere close to the current state.
621,371 * 0.65 = 403,891 crits during burst (doesn't even do this much)
746,392 * 0.65 = 485,154 crits during burst (should be this much at least)

And here's how much it actually does, I cant even crit more than 350k:
https://youtube.com/watch?v=mxwmzfK4GnI:


https://youtube.com/watch?v=KDme6VVCQic:



I cant hit harder than 350k crit with my full burst up and while stunned, he literally has to have 75-80% damage reduction by default in order to hit that low, which is nonsense.

I think there's enough proof, correct me if I made mistake somewhere and I will redo calculations.

#Edit Found another proof
https://youtube.com/watch?v=CIPxydAXs9M&t=140:



He does 590,506 crit on assassination rogue twice in a row (timestamp 2:22).
Assa rog has about 27% armor reduction in instanced pvp, based on my rogue 964 ilvl, and 8% def versatility.
If you add back those numbers to this crit:
590,506 / 65 * 27 = 245,287
590,506 / 65 * 8 = 72,677
590,506 + 245,287 + 72,677 = 908,470‬ (his non reduced damage)
But nightblade 15% bonus and Prey on the weak 10% bonus arent shown on tooltip, and also this is crit, so when we remove those:
718,157 / 182 * 100 = 499,159
499,159 / 115 * 100 = 434,051
434,051 / 110 * 100 = 394,591 (his tooltip)

218,770.3‬ * 1.3 (Dark Shadow talent) * 1.1 (Symbols of Death) * 1.1 (Master of Subtlety) * 1.1 (Thief's Bargain) = 378,538 (tooltip that should be by my calculations, I assume that's gear difference or simply because he is human and gets a bit more stats)

As always if I did mistake somewhere, correct me to redo the math.

[Bow]

https://imgur.com/a/u5Xi6bA


First 2 pictures are of a naked rogue with just artifact weapon and 0 traits, tooltip and damage are the same

Next 2 pictures are again naked rogue with just artifact weapon and 1 trait (4% damage increase (Shadow fangs)), tooltip and damage are the same

Last 2 pictures are again naked rogue with just artifact weapon and 21 traits among which the 4% increase and 3/3 Precision Strike, tooltip and damage are again the same


Overall again a very good report, but as you can see the trait works correctly.

Guild Master and Raid Leader of