[DUPLICATE] [Shaman][Enhancement] Windfury Proc, Stormbringer Proc

[Doctor Who]

WoW Freakz spell link:

https://www.wow-freakz.com/spells.php?spell=33757&&name=windfury
https://www.wow-freakz.com/spells.php?spell=201845&&name=stormbringer



Bug description: Proc chance is randomly lower than it should be
Proof:

https://streamable.com/099j69

Enhancement shaman, no gear equipped, two 1.6 speed daggers. Base stats calculation only.

417 valid hits according to details log
had 13 procs of stormbringer, and 44 hits (that's 22 procs) of windfury
correct hits according to percentages should have been 23 stormbringers and 41x2 (cause windfury causes two attacks according to the tooltip) so 82 windfurys



Autoattacks:
https://streamable.com/t3qzf0

I counted 16 procs of stormbringer instead of 28, on 503 valid attacks
35 casts 70 hits on Windfury, instead of 47 casts 94 hits.



a 5.6% proc chance on 500 attacks can fluctuate between 5.2 % and 6% (people call it an unlucky pull, or a lucky pull) not go down as low as 3.2% and never reach the tooltip of 5.6%



Using warcraft logs as proof:

https://www.warcraftlogs.com/reports/A2dCT6Lh1fNpvYkx#fight=3&&type=auras&&source=3 - 17 procs (about 6 procs per minute)
fight on Garothi, 99.59% active time

3:29 min fight (about 46 seconds longer) https://www.warcraftlogs.com/reports/RvfZ21FParXBnm6c#fight=3&&type=auras&&source=9 - 51 procs (about 14.5 procs per minute)

https://www.warcraftlogs.com/reports/RvfZ21FParXBnm6c#fight=3&&type=auras&&source=17 (same raid as the guy above, but with 50 procs, still above 14 procs per minute )


3:24 fight https://www.warcraftlogs.com/reports/AWnYd4VZJ8yhmGxf#fight=1&&type=auras&&source=5 0 50 procs (still 14+ procs per minute)

If you check the logs, they had less than 99.59% active time


Using the logs and the videos above mentioned, checking Windfury hits, the proc chance appears to be lower aswell. The video shows the valid attacks and the procs. The logs show the following:

On retail, an enhancement shaman with mastery between 10k and 12.5k and 15k haste does more windfury procs than an enhancement shaman with 15k mastery and 15k haste.
On retail, an enhancement shaman with mastery between 10k and 12.5k and 15k haste does more Stormbringer procs than an enhancement shaman with 15k mastery and 15k haste.

Logs were random, on shamans on 3.000 - 5.000 positions on warcraftlogs, 970 to 976 item level, and compared to a 989 ilvl enhancement shaman on freakz.

[Naicuv]

I've also done a 6h parse at the dummy with 2.60 speed maces, no other gear on. (https://www.wow-freakz.com/item_finder.php?item=2492&&name=cudgel -weapon link)

These were my results:
Melee hits: 17484 (8742 main hand + 8742 offhand)
Windfury attack: 2824 -1412 procs
Stormbringer: 549 procs

Windfury: 20.64% chance to proc/main hand attack
Stormbringer: 5.64% chance to proc/every weapon attack

Average normal amount of windfury procs: 8742 (main hand melee) *20.64/100= 1804 (3608 hits)
Average normal amount of stormbringer procs: (17484+2824) *5.64/100=1145
Average normal amount of stormbringer procs if windfury worked: (17484+3608)*5.64/100=1189


Right now the percentages on freakz look like this:

Windfury chance to proc:

1412 procs.................................x
8742 main hand attacks............100

1412*100/8742=16.15
16.15% chance to proc instead of 20.64%

Stormbringer chance to proc:

549 procs...................................x
20308 weapon attacks..............100

549*100/20308=2.70

2.70% chance to proc instead of 5.64%

Considering I've done the test in 6 hours and around 17500 melee hits I think the percentages should be correct, not just RNG

Proof:
https://imgur.com/a/phPfPjF
https://imgur.com/a/Wv1IHhN
https://imgur.com/a/Axxe4Sd -melee hits
https://imgur.com/a/b3iPVYo -windfury hits
https://imgur.com/a/8gytBlF -stormbringer procs
https://www.wow-freakz.com/spells.php?spell=33757 -windfury
https://www.wow-freakz.com/spells.php?spell=201845 -stormbringer

[Skillshot]

daikfunka wrote:

ayyy now its just a matter of waiting 3 weeks for the shaman class mod to look at this and say '' this is all cool n'all but not enough proof ''

Not about the shaman class mod. Devs looked into it - they can't confirm nor reproduce it. All of the above were acknowledged by the class mod and reported to the devs, it's known that the procs are lower, they just say it's "rng".
Probably that's the way the proc chance is implemented for the current game core.
Unless someone with higher knowledge or position pushes this, it's going to be just another topic.

My guess is that this was around for a long time, but came to light when they fixed stormbringer.

[Naicuv]

Almost 18000 worth of attacks with half the procs is virtually impossible, it's not rng, it's bugged.

[Skillshot]

Naicuv wrote:

Almost 18000 worth of attacks with half the procs is virtually impossible, it's not rng, it's bugged.

Probability is not always straightforward. But chance for a proc in game should be programmed in the way that the expected amount should be close to equal to the actual one.
That’s how it worked on retail, that’s how Simcraft shows it, also the devs or whoever hopefully reads this and has at least a bit of understanding should take into account that a 300 seconds simmed encounter in simcraft returns the proc chances exactly similar to what your stats are. A 300 seconds encounter with a much higher error margin.

Here is an article how it should generally work, not necessarily applicable to Freakz, just as a concept https://www.gamasutra.com/blogs/RogerHgensen/20101123/88511/Chance_Probability_Luck_Percentage_calculation_for_games.php

[Naicuv]

No problem then, I can do as many 6 hours or more parses as the class mod or dev would like, as long as it proves the proc chance is bugged, because I'm sure I won't get close to the expected amount of procs in any try.

[zeakey]

Hi all,

I know I am not a shaman mod but here is a little advice.

Can you please have a look at https://www.warcraftlogs.com/ legion loggs.

Try to find an enchantment shaman logs with all strombringer procs with accurate maths backing it up. Make sure you consider the exact amount of mastery and the exact percentage of Stormbringer proc realtime since these values vary due to have many buffs and debuffs you get during the raid.

Best of luck,

Zeakey.

[Naicuv]

First of all, the formula of mastery is N*0.005+16 base, and the extra chance to proc stormbringer is Mastery%*0.04


First log: https://www.warcraftlogs.com/reports/wDTW1Vr2atM7jKpJ#fight=14&&type=damage-done&&source=20

Mastery: 14052*0.005+16 base=86.26% mastery => 86.26*0.04= 3.45 extra chance to proc stormbringer -8.45 in total

Stormstrike hits: 342
Windstrike hits: 150
Lava lash hits: 72
Windfury hits: 388
Crash lightning hits: 101
Melee hits: 449
Windlash: 133
Rockbiter hits: 137
Flametongue hits: 36

Total stormbringer procs: 132

Total valid hits to generate stormbringer: 342+150+72+388+101+449+133+137+36=1808

Expected procs: 1808*8.45/100=152

Second log: https://www.warcraftlogs.com/reports/ngZ1rhJcTpPmRdzB#fight=1&&type=damage-done&&source=18

Mastery: 12342*0.005+16 base=77.71% mastery => 77.71*0.04=3.10 extra chance to proc stormbringer -8.10 in total

Stormstrike hits: 422
Windstrike hits: 258
Windfury hits: 455
Lava lash hits: 48
Crash lightining hits: 114
Melee hits: 447
Windlash hits: 185
Rockbiter hits: 128
Flametongue hits: 47
Frostbrand hits: 4

Total stormbringer procs: 175

Total valid hits to generate stormbringer: 422+258+455+48+114+447+185+128+47+4=2108

Expected procs: 2108*8.10/100= 171

Third log: https://www.warcraftlogs.com/reports/yFXL6PH4kdQvAWmG#fight=2&&type=damage-done&&source=87

Mastery: 10,402*0.005+16 base=68.01% mastery => 68.01*0.04=2.72 extra chance to proc stormbringer -7.72 in total

Stormstrike hits: 372
Windstrike hits: 214
Lava lash hits: 67
Windfury hits: 389
Crash lightning hits: 97
Melee hits: 425
Windlash hits: 168
Rockbiter hits: 133
Flametongue hits: 43

Total stormbringer procs: 160

Total valid hits to generate stormbringer: 372+214+67+389+97+425+168+133+43=1908

Expected procs: 1732*7.72/100= 147

Fourth log: https://www.warcraftlogs.com/reports/YwFLkyhD7Cr4Zg3c#fight=12&&type=summary&&source=40

Mastery: 13176*0.005+16 base=81.88% mastery => 81.88*0.04=3.27% extra chance to proc stormbringer -8.27% in total

Stormstrike hits: 388
Windstrike hits: 170
Lava lash hits: 75
Windfury hits: 387
Crash lightning hits: 135
Melee hits: 429
Windlash hits: 149
Rockbiter hits: 136
Flametongue hits: 35

Total stormbringer procs: 149

Total valid hits to generate stormbringer: 388+170+75+387+135+429+149+136+35=1904

Expected procs: 1904*8.27/100= 157


Fifth log: https://www.warcraftlogs.com/reports/7ZVrqyD4TaH8QNzd#fight=28&&type=summary&&source=16

Mastery: 10620*0.005+16 base=69.10% mastery => 69.10*0.04=2.76% extra chance to proc stormbringer -7.76% in total

Stormstrike hits: 328
Windstrike hits: 162
Lava lash hits: 81
Windfury hits: 396
Crash lightning hits: 68
Melee hits: 416
Windlash hits: 150
Rockbiter hits: 128
Flametongue hits: 36

Total stormbringer procs: 133

Total valid hits to generate stormbringer: 328+162+81+396+68+416+150+128+36=1765

Expected procs: 1765*7.76/100=137

As you can see, the expected procs and actual amount of procs are different because RNG is involved, but still close because these are relatively long fights. Obviously, the longer the fight, the more consistent the results are.

EDIT: added rockbiter, flametongue and frostbrand hits.

[telesto]

Nice try. But you have forgot to include Rockbiter, Flametongue and Frostbrand initial damage in to your calculation. Please learn class before making any claims.

[Naicuv]

I didn’t forget them, I just didn’t include them, because they are not weapon attacks, so they don’t proc stormbringer

[florinflo99]

https://www.warcraftlogs.com/reports/PhBNTMncrDmfd6VZ/#fight=1&&&&type=auras&&&&source=7

Logs from wow freakz 7.8.2020 Enhancement shaman 91t 989 gear , here you can see 39 procs of stormbringer in 3:01 minutes compared to blizzard (181 sec:39 procs = 1 procs every 4.64 seconds)

https://www.warcraftlogs.com/reports/DJW2zCdR9vq6HkhZ#fight=3&&&&type=auras&&&&source=6 55 PROCS of STORMBRINGER in 3:00 minutes (180 sec:55procs=1 proc every 3,27 seconds)

also same boss https://www.warcraftlogs.com/reports/Cp29dYTHcrBjGKW8#fight=3&&&&type=auras&&&&source=30 64 PROCS in 3:22(202 sec:64procs=1 proc every 3,15seconds)


compared this logs you can see the diference of procs is aprox proc rate on blizzard on first case is 141,896% resulting 41,896% bigger then on freakz
for second log is 147,301% ,47,301% bigger then on freakz


This is the most accurate log you can have here,compare freakz log with blizz log

[Shammybro]

So yea, stormbringer proc chance is definitely off, looking trought the warcraft logs, the amount of procs on retail is from what I've seen never lower than the average number (when you sum up all the spells that can proc it and divide by mastery%) while as it currently stands the number of procs we get on freakz is substantially lower almost every time, I'll need to do more testing (when im able to since im repairing my PC atm). Until then please refrain from unnecessary comments.

Update @ 13-08-2020, 12:42:05

Naicuv wrote:

I didn’t forget them, I just didn’t include them, because they are not weapon attacks, so they don’t proc stormbringer

https://imgur.com/AvJNYjr

[Naicuv]

Shammybro wrote:

So yea, stormbringer proc chance is definitely off, looking trought the warcraft logs, the amount of procs on retail is from what I've seen never lower than the average number (when you sum up all the spells that can proc it and divide by mastery%) while as it currently stands the number of procs we get on freakz is substantially lower almost every time, I'll need to do more testing (when im able to since im repairing my PC atm). Until then please refrain from unnecessary comments. Update @ 13-08-2020, 12:42:05 Naicuv wrote: I didn’t forget them, I just didn’t include them, because they are not weapon attacks, so they don’t proc stormbringer https://imgur.com/AvJNYjr

I updated the post, thought they aren't weapon attacks considering they didn't proc Flametongue attack.

[Neunia]

Can we guys please talk about how he was doing testing with two daggers and based his whole report on it?

[se7enspree]

Neunia wrote:

Can we guys please talk about how he was doing testing with two daggers and based his whole report on it?

Daggers got the fastest speed. More auto atks = more procs. Since what he does there is calculate procs and not dmg.